-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: use local mutable sources for props in legacy mode in case they are indirectly invalidated #16038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+288
−95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
…are indirectly invalidated
🦋 Changeset detectedLatest commit: 4febc9e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Loading status checks…
Rich-Harris
commented
May 30, 2025
Loading status checks…
Loading status checks…
Loading status checks…
…te into legacy-indirect-reactivity
Loading status checks…
Loading status checks…
elliott-with-the-longest-name-on-github
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a real strange one. There's a test,
binding-input-text-contextual-reactive
, that passes onmain
but doesn't work in a real app (try editing the items — the summary never updates).The diff below fixes it, but I cannot for the life of me make the test fail without it.
Update okay I managed to add a new test that fails on
main
. The new code makes more sense, I'm surprised the bug remained hidden as long as it did.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint